Typed message protocol between UI and worker#101
Merged
Conversation
|
@Aditya8369 is attempting to deploy a commit to the csxark's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
csxark
approved these changes
Jul 9, 2026
csxark
left a comment
csxark
left a comment
Owner
There was a problem hiding this comment.
Great work @Aditya8369, and thank you for your contribution! 🎉I've reviewed the changes, and everything looks good. The requested fixes have been addressed correctly, and the implementation aligns well with the requirements. This is ready to be merged. Looking forward to your future contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have successfully completed implementing the Typed Message Protocol between the UI hook and the background Web Worker.
Summary of Changes
types/worker.ts (NEW):
Defined strict interfaces for WorkerRequest ({ type, requestId, payload }) and WorkerResponse ({ requestId, success, payload, timings }).
lib/hooks/useCipherWorker.ts:
Refactored the hook to compile and JSON-serialize the strictly structured request payload.
Refactored onmessage handling to validate and process responses conforming to WorkerResponse.
lib/workers/cipher.worker.ts:
Refactored parameters destructuring directly out of the typed payload request object.
Enforced total job execution timing tracking using performance.now().
Sent strictly structured response messages containing calculation results/errors and timings.
tests/unit/hooks/useCipherWorker.test.ts:
Refactored the unit test suite to fully type-check requests and responses. All unit tests successfully compiled and passed.
closes #82